LGA-1726 - Update education script notes and add logic for default ones

mayowaadeniyi commented 3 years ago

What does this pull request do?

Update education script notes
Add some logic so we show the default script notes for non education cases

Any other changes that would benefit highlighting?

Checklist

[x] Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

exonian commented 3 years ago

Due to the way the app currently works, you can pick education as your start category and end up with your case being classed as discrimination due to what you pick later in the form. For anyone this happens to, they will see the default script notes and not the updated education ones

Are you saying that a) you want the education->discrimination user to be shown the education notes, but due to the way the category gets replaced this isn't currently possible and we're having to settle for this behaviour? or b) we are always showing the notes we want to show, and you're highlighting that this is correct even when the user starts their journey in education but ends up in another category?

mayowaadeniyi commented 3 years ago

Due to the way the app currently works, you can pick education as your start category and end up with your case being classed as discrimination due to what you pick later in the form. For anyone this happens to, they will see the default script notes and not the updated education ones

Are you saying that a) you want the education->discrimination user to be shown the education notes, but due to the way the category gets replaced this isn't currently possible and we're having to settle for this behaviour? or b) we are always showing the notes we want to show, and you're highlighting that this is correct even when the user starts their journey in education but ends up in another category?

I just wanted to highlight that. Tbh now that I think about it, that's how the app works, so it's not an issue at all.

ministryofjustice / cla_frontend