said-moj
commented
2 years ago I think the reason the github url rewrites were required because of https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/
No more unauthenticated Git On the Git protocol side, unencrypted git:// offers no integrity or authentication, making it subject to tampering. We expect very few people are still using this protocol, especially given that you can’t push (it’s read-only on GitHub). We’ll be disabling support for this protocol.
If that is the case you might want to mention that in your PR
What does this pull request do?
Add maintenance mode configmap and nginx annotation, this should enable us to turn maintenance mode on.
Amended the dockerfile to make sure that NPM packages were downloaded correctly:
https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/
Any other changes that would benefit highlighting?
Intentionally left blank.
Checklist