Closed said-moj closed 2 years ago
Move the JS unit tests dependencies into optionalDependencies
Should not have and do not need these JS unit tests dependencies in the production image
The optional dependencies are installed as part of CI pipeline when they are needed
PhantomJS is no longer being supported and does not have arm64 image available so it breaks image builds on arm64 architectures(Apple M1)
NPM v6 does not support --omit flag so this is the only way to have the prod and dev dependencies installed and not these unit test dependencies
What does this pull request do?
Move the JS unit tests dependencies into optionalDependencies
Any other changes that would benefit highlighting?
Should not have and do not need these JS unit tests dependencies in the production image
The optional dependencies are installed as part of CI pipeline when they are needed
PhantomJS is no longer being supported and does not have arm64 image available so it breaks image builds on arm64 architectures(Apple M1)
NPM v6 does not support --omit flag so this is the only way to have the prod and dev dependencies installed and not these unit test dependencies
Checklist