ministryofjustice / cla_frontend

CLA Front End
http://ministryofjustice.github.io/cla_docs/
MIT License
3 stars 4 forks source link

LGA-2631 Adding under 18 questions and answers to the legal help form #914

Closed psweeting1 closed 1 year ago

psweeting1 commented 1 year ago

What does this pull request do?

Updating template for the Legal Help Form to reflect the changes performed by a specalist provider when selecting and saving answers around 18 and under.

Any other changes that would benefit highlighting?

if ec["is_you_under_18"] and not ec["under_18_receive_regular_payment"]:
            ec["under_18_investments_totalling"] = True

This code was created and is adding to simply the logic used in the jade template. Jade template is so old it can not handle & in it's if statements. This was a cleaner solution than having nested if conditions.

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication