search

ministryofjustice / cla_frontend

CLA Front End
http://ministryofjustice.github.io/cla_docs/
MIT License
3 stars 4 forks source link

LGA-2753 replace old ga with tagman #931

Closed digitalali-moj closed 1 year ago

digitalali-moj commented 1 year ago

What does this pull request do?

Remove old Google analytics code and add new Google Tag Manager code. This makes Google analytics tracking work for all pages.

Any other changes that would benefit highlighting?

Yes, this is very unlikely to ever change so is hard coded as it's simpler that way.

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

digitalali-moj commented 1 year ago

Should this tag work and be the same across all environments(including local)?

Yes this is for all environments and should work on all too. We can filter results in GA4 reports when needed. We can also disable non-prod on Tagman. But I'm guessing it's not a lot of traffic on non-prod?