Github action and/ or gatekeeper policy to catch illegal characters (and possibly duplicate uids unless out of scope? ) - Githubissues

ministryofjustice / cloud-platform

Documentation on the MoJ cloud platform

MIT License

87 stars 44 forks source link

Github action and/ or gatekeeper policy to catch illegal characters (and possibly duplicate uids unless out of scope? ) #5522

Open jaskaransarkaria opened 6 months ago

jaskaransarkaria commented 6 months ago

Background

Prometheus uids can only contain certain characters (and must also be unique)

https://mojdt.slack.com/archives/C8QR5FQRX/p1714058732406509 https://mojdt.slack.com/archives/C57UPMZLY/p1713976933582079

Proposed user journey

Approach

Which part of the user docs does this impact

Communicate changes

[ ] post for #cloud-platform-update
[ ] Weeknotes item
[ ] Show the Thing/P&A All Hands/User CoP
[ ] Announcements channel

Questions / Assumptions

Definition of done

[ ] readme has been updated
[ ] user docs have been updated
[ ] another team member has reviewed
[ ] smoke tests are green
[ ] prepare demo for the team

Reference

How to write good user stories

poornima-krishnasamy commented 5 months ago

I would prefer doing it as a gatekeeper policy as not all grafana dashboards are PR'ed in cloud-platform-environments to catch it as a github action.