search

ministryofjustice / cotton

Project independent shared fabric extensions to bootstrap first VM and manage configuration within team
3 stars 2 forks source link

Add ability to load Vagrant project.yaml #43

Closed mikepea closed 10 years ago

mikepea commented 10 years ago

For Vagrant-based deploys, we want to remove the need to have the config repo present.

If env.provider_zone contains 'vagrant', load a local project.yaml file from ./vagrant/project.yaml

mikepea commented 10 years ago

@ashb can haz merge pls?

ashb commented 10 years ago

Looking over this diff again (sorry). Is there a reason we can't achieve this via the COTTON_CONFIG environment variable already? Do many/any other projects have a vagrant/ folder?

mikepea commented 10 years ago

I don't think any other projects use Vagrant in earnest yet, it's a common pattern for vagrant specific files though.

Setting an envvar means that I have shell mangling to do to switch between zone:vagrant and zone:staging (eg), which is really prone to error.

On 1 October 2014 09:47, Ash Berlin notifications@github.com wrote:

Looking over this diff again (sorry). Is there a reason we can't achieve this via the COTTON_CONFIG environment variable already? Do many/any other projects have a vagrant/ folder?

— Reply to this email directly or view it on GitHub https://github.com/ministryofjustice/cotton/pull/43#issuecomment-57435368 .