MatMoore
commented
7 months ago @jemnery I think this inconsistency has come about because we've diverged from the design.
The figma doesn't use the summary list component, and instead just has one item per line with a colon. I think we just implemented this pattern of our own accord early on and never updated it, and the one in the figma is how it should be.
Previously I corrected this on the details page by using a govuk list instead of govuk summary list. The result looks like this:
I reckon we should do the same thing on the search results page. Not using the summary list also means we can use a horizontal line break to separate the actual results, as in this DFE example:
What do you think @alex-vonfeldmann ?
jemnery
YvanMOJdigital
Change to match the patterns in figma. Fix on the seach results and details page.
The content of terms in description lists have inconsistent use of colons.
The examples in the design system don't use colons. I assume because the
<dl>itself creates logical separation and we don't need colons.Can we create a Selenium test for this? 🤔