Add text where no results

ministryofjustice / find-moj-data

Find MOJ data service • This repository is defined and managed in Terraform

MIT License

5 stars 0 forks source link

Add text where no results #601

Open seanprivett opened 2 months ago

seanprivett commented 2 months ago

Default values for where metadata is blank for:

If domain is blank, assign the domain of "General"
If request access is blank:

if no value but data owner is present - "Contact the data owner to request access"
if no value and no data owner - "Not provided"

If contact channel for questions is blank:

if no value but data owner is present - "Contact the data owner with questions"
if no value and no data owner - "Not provided"

If data owner is blank - "Not provided - contact the Data Catalogue team about this data"
Please also update the label "Contact channels for questions" to "Ask a question"
These fields should show at all times.

tom-webber commented 2 months ago

Not provided?

markjefferson-gov commented 2 months ago

@seanprivett Couple of thoughts about this:

Is there any functional difference between showing some default text when the domain is blank and just assigning a domain? We have an existing domain of 'general' which is so vague I think it would suit as a catch-all bucket until we have a chance to review domains properly.
Depending on the data, I'm assuming request access and contact channels are essential and their absence would be a dead end for the user. I appreciate this will hopefully be an edge case. How would you feel about us giving our team contact info in that scenario?

seanprivett commented 2 months ago

@markjefferson-gov I think general is a good idea for those that don't have a domain

I think in the early days of the catalogue, entries without access or contact channel details may be the majority, so it could result in us being swamped.

markjefferson-gov commented 2 months ago

Discussed at UCD catchup. Sean to look into likelihood of missing access and contact info.

MatMoore commented 2 months ago

@markjefferson-gov

Is there any functional difference between showing some default text when the domain is blank and just assigning a domain? We have an existing domain of 'general' which is so vague I think it would suit as a catch-all bucket until we have a chance to review domains properly.

Yes - if no domain is assigned the thing will be harder to find, because it won't be reachable by browsing, and if the user interacts with the domain filter the behaviour will be a bit unintuitive.

To use general as the catchall bucket we will need to update our ingestion code for Justice Data to set the "Justice Data" dashboard to General, and also the remaining charts which don't have a suitable domain yet (I make this 52 charts)

Domains for CaDeT databases and tables are fully populated, so no change required there.

MatMoore commented 2 months ago

Discussion regarding how to request access default: https://mojdt.slack.com/archives/C03QZ776JVA/p1723196543249529?thread_ts=1723133391.430389&cid=C03QZ776JVA

I will add in messages to support falling back to contact or owner as an alternative to the generic message:

Access info is missing, but there is a contact
Access info and contact is missing, but there is an owner

markjefferson-gov commented 2 months ago

Discussed and agreed required behaviour and default values with Mat and Sean on Slack. Updated the ticket description with what we agreed.