ministryofjustice / help-with-prison-visits-external

https://www.gov.uk/help-with-prison-visits
MIT License
10 stars 3 forks source link

Migrating project to use groups in allowlist #848

Closed andrewrlee closed 11 months ago

andrewrlee commented 11 months ago

This PR migrates the project to use groups of IPs in their allowlist.

By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses. If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs.

2 allowlist(s) have been detected that can be migrated.

Allowlist: helm_deploy/values-dev.yaml

New Groups

The effect of applying this PR is as follows:

Added IPs

The new Group membership will result in the following IPs being added to your allowlist by applying this PR:

Removed IPs

The following IPs have been identified as unnecessary and will be removed by applying this PR:

Allowlist: helm_deploy/values-preprod.yaml

New Groups

The effect of applying this PR is as follows:

Added IPs

The new Group membership will result in the following IPs being added to your allowlist by applying this PR:

Removed IPs

The following IPs have been identified as unnecessary and will be removed by applying this PR: