search

ministryofjustice / help-with-prison-visits-external

https://www.gov.uk/help-with-prison-visits
MIT License
10 stars 3 forks source link

HWPV-165 update govuk-frontend version to reflect new crown logo #856

Closed pk2453 closed 8 months ago

simonnebMOJ commented 8 months ago

LGTM - do not merge until Monday 19 February

simonnebMOJ commented 8 months ago

@pk2453 apologies - only just got chance to look at this.

I haven't tested (so do double check!) but I don't think you need to actually add the image files in assets/images because these are set up (in app.js) to be served directly from the govuk-frontend source in node_modules. In fact, including them in our repo means we wouldn't ever get any changes that might be released from the module.

In the release notes, it says to:

...copy these to your service's image assets folder if they are not being used directly from the Frontend package...

We are serving directly from the Frontend package I think.

That was me @tpmcgowan - have now removed

tpmcgowan commented 8 months ago

That was me @tpmcgowan - have now removed

Apologies to Pankaj then - I didn't read the commit history closely enough 😂