ministryofjustice / hmpps-delius-bastion

Bastion servers for the Delius migration project.
1 stars 1 forks source link

Removing references to the peering connections to bastion vpc #87

Closed adeweetman-al closed 2 years ago

adeweetman-al commented 2 years ago

Associated to https://dsdmoj.atlassian.net/browse/NIT-151

Removing these references does 2 things

Note the code that references these changes is based on counts and list lengths (eg. https://github.com/ministryofjustice/hmpps-delius-bastion/blob/master/bastion-vpc/peering.tf#L6) , the terraform apply essentially reorders the entire list, resulting in: Plan: 91 to add, 0 to change, 105 to destroy.

It effectively drops 14 items permanently and replaces the remainder under different list elements. The 14 can be accounted for as

This will be applied locally when this PR is approved.