search

ministryofjustice / justice-gov-uk

Justice UK website
https://www.justice.gov.uk/
MIT License
2 stars 0 forks source link

Update Makefile #15

Closed EarthlingDavey closed 9 months ago

EarthlingDavey commented 9 months ago

in local-stop. Prevent a non-zero exit code when kind-control-plane is not found.

EarthlingDavey commented 9 months ago

@wilson1000-MoJ this is just for your consideration. You may have a better solution.

Also, I noticed that make d-compose will create 2 php containers. And make down will leave one of them running.

Is the solution to have just 1 php container start on make d-compose or to add to make down to down both php containers? Or something else?

wilson1000-MoJ commented 9 months ago

@wilson1000-MoJ this is just for your consideration. You may have a better solution.

Also, I noticed that make d-compose will create 2 php containers. And make down will leave one of them running.

Is the solution to have just 1 php container start on make d-compose or to add to make down to down both php containers? Or something else?

Yes, one container is the app that you can access over the browser. The other is a service container for the user to use to run commands against the application. The user should exit out of this when they are done.

wilson1000-MoJ commented 9 months ago

in local-stop. Prevent a non-zero exit code when kind-control-plane is not found.

Was this causing an issue locally for you?

EarthlingDavey commented 9 months ago

Was this causing an issue locally for you?

Yes, locally make d-compose was erroring, because it was calling local-stop. I could have explained better 🙃