search

ministryofjustice / justice-gov-uk

Justice UK website
https://www.justice.gov.uk/
MIT License
2 stars 0 forks source link

CDPT-1755: To the top #233

Closed EmilyHazlehurst closed 2 months ago

EmilyHazlehurst commented 3 months ago
EmilyHazlehurst commented 2 months ago

Hey @EmilyHazlehurst , what you've done looks good, but I have some doubts about weather it could be simplified.

We have quite a few files and some DOM creating and parsing, for a what is (or nearly is nearly?) a static component.

Do you think it would be possible to simplify it without losing the benefits of the standalone frontend folder & Storybook?

@EarthlingDavey thanks for the feedback.

I understand what you're saying, my thoughts were that blocks should be handled consistently so that the codebase is easy to read and understand.

I did a load speed comparison between the original component and this one and there wasn't a noticeable difference, but you're right in that it might be a problem as more blocks are made or on longer pages.

I'm going to merge this now but have made a ticket to look into this again after the static components are finished just to ensure it won't add unnecessary overheads and to look at other options.