Open wilson1000-MoJ opened 8 months ago
@EarthlingDavey says:
Here, we could be missing assets from recently installed packages.
composer.lock
has a content-hash
property.
After we generate vendor-assets
could we write the content-hash value to vendor-assets/composer-lock-hash.txt
?
And add an additional check to this conditional, like the following pseudo code.
if [ ! -d "./vendor-assets" OR composer-lock-hash.txt != composer.lock.content-hash ]; then
_Originally posted by @EarthlingDavey in https://github.com/ministryofjustice/justice-gov-uk/pull/64#discussion_r1503816537_
This looks good, I have a suggestion to consider, which is very much a matter of preference.
Is there potential for this to be
@docker compose exec php-fpm composer install
.And, leverage the composer script hook post-install-cmd, to run the following?
_Originally posted by @EarthlingDavey in https://github.com/ministryofjustice/justice-gov-uk/pull/64#discussion_r1503809185_