AP-5453: CYA truelayer transaction bug

[colinbruce]

What

Link to story

This PR addresses a bug found while working on #7340 where a user returning to the Payments your client receives page from CYA would see payments that had been selected for a partner too

While resolving that, another bug was found where a payment that has been assigned to a category which was subsequently removed, cannot be re-assigned to a category (new or the previous one if re-enabled)

• Update checkbox selection on incoming truelayer, CYA path
• Update meta-data handling after incoming and outgoing checkboxes are cleared
• Update checkbox selection on outgoing truelayer, CYA path
• Update CYA routing when a provider selects no payments
• Update routing after the identify_* pages, there were routes that could be reached that were weird!

Checklist

Before you ask people to review this PR:

• Tests and rubocop should be passing: bundle exec rake
• Github should not be reporting conflicts; you should have recently run git rebase main.
• The standards in the Git Workflow document on Confluence should be followed
• There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
• The PR description should say what you changed and why, with a link to the JIRA story.
• You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
• You should have checked that the commit messages say why the change was made.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[colinbruce]

Good shout on the rename - it was a temp fix to see if it would work, but the updated name is more accurate :+1: