AP-5143: initiate state machine after create

[jsugarman]

What

Initiate state machine after application creation

Link to story

With the removal of this hook an inadvertent side effect has been removed

  after_create do
    ActiveSupport::Notifications.instrument "dashboard.application_created", id:, state:
  end

The calling of the state method in this code means it actually calls state_machine_proxy method, which creates a state_machine relation on the application if it does not have one. Its removal therefore opens up issues both in tests and possibly functioning of the app.

By replacing it with an explicit call to state_machine_proxy we avoid the issue.

Checklist

Before you ask people to review this PR:

• Tests and rubocop should be passing: bundle exec rake
• Github should not be reporting conflicts; you should have recently run git rebase main.
• The standards in the Git Workflow document on Confluence should be followed
• There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
• The PR description should say what you changed and why, with a link to the JIRA story.
• You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
• You should have checked that the commit messages say why the change was made.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud