search

ministryofjustice / laa-fee-calculator

Fee calculator for LAA
MIT License
3 stars 3 forks source link

Rename `case_date` to `enforced_at` #43

Open jsugarman opened 6 years ago

jsugarman commented 6 years ago
What

For discussion - Rename fee scheme case_date to enforced_at

Why

This is a nice to have. typical use of the API by CCCD will likely choose the scheme based on scheme type: AGFS | LGFS and case_date. naming wise this makes more sense as the scheme that was enforced_at a date

e.g. 

client.fee_schemes(type: 'AGFS', enforced_at: '2018-03-31')
=> agfs scheme 9 object

client.fee_schemes(type: 'AGFS', enforced_at: '2018-04-01')
=> agfs scheme 10 object

The case date will be supplied with the earliest representation order date for a claim in CCCD

jsugarman commented 6 years ago

hold off on doing anything on this as the naming as above is not quite right either