ministryofjustice / mkdocs-tech-docs-template

Build flexible technical documentation with a GOV.UK style using MkDocs
https://ministryofjustice.github.io/mkdocs-tech-docs-template/
8 stars 4 forks source link

Fix spacing issue when using navigation.sections without navigation.tabs #13

Closed michalc closed 1 year ago

michalc commented 1 year ago

When using navigation.sections without navigation.tabs, there were two issues:

This fixes both of these issues by

This shows the issue before this PR, which are the docs for this template itself, but changed to use sections but no tabs

sections-without-tabs-issue

And this shows the docs using the code in this PR

sections-without-tabs-fixed

This should address https://github.com/ministryofjustice/mkdocs-tech-docs-template/issues/12

SoumayaMauthoorMOJ commented 1 year ago

Thanks for raising @michalc ! If I apply your changes The TOC headings on the right lose the blue highlight: image

Any suggestions?

michalc commented 1 year ago

@SoumayaMauthoorMOJ ~Ah I didn't notice that bit. I think I've now addressed that in the current version of this PR?~ ~Hold off... not sure~

Ok I think I have now addressed that

michalc commented 1 year ago

Thanks for the approval and merge!