dms1981
commented
1 year ago The following PR solves the automation step - https://github.com/ministryofjustice/modernisation-platform/pull/3523 I've made all the manual changes I can, but have noted that some environments don't appear to allow me to attach the relevant teams to their environmental approvers:
- mi-platform-development missing analytical-platform
- analytical-platform-data-* missing analytical-platform & analytics-hq
- analytical-platform-management-* missing analytical-platform & analytics-hq
- remote-supervision-* missing hmpps-remote-supervision
- bichard7-* missing cjse-bichard7-next
User Story
As an MP engineer I should not be making deployments to user infrastructure So that I don't accidentally interfere with users work
User Type(s)
MP engineers
Value
Prevent accidental deployments to user infrastructure
Assumptions / Hypothesis / Questions / Unknowns
Hypothesis
If we remove MP team deployment rights Then we will not be able to make deployments
Proposal
Modify the github environments script to not add MP team as a reviewer - https://github.com/ministryofjustice/modernisation-platform/blob/main/scripts/git-create-environments.sh
On the environments repository, manually remove the MP team from all environments (you may want to script this, but it's probably quicker as a one off to do manually).
Unknowns
The GitHub script changes will need to be tested locally and carefully on one of our environments first as to not impact everyone. The script will loop through all envs so this will need to be modified to run against only one. -->
Definition of done
Reference
How to write good user stories