Spike: Update account creation system to support isolated networking.

ewastempel commented 9 months ago

User Story

As an MP engineer I want to be able to provision accounts with isolated networking through a standard process So that new accounts that use isolated networking have the same/similar shape as the existing member accounts.

Value / Purpose

Standardised account creation mechanism means that we can provision/update all of the member accounts in the same way without thinking about the differences between them. It limits a human error when it is done through code/automation, rather than manual code changes to the environment after the member account creation with the existing processes.

Useful Contacts

No response

Additional Information

Isolated networking accounts will not require:

Unique CIDR address ranges
Connectivity to Modernisation Platform Transit Gateway

Additionally they will require:

Consideration as to how we populate the environments/$application.json to supply an isolated subnet set
How this json value is picked up by our automation
What files we populate into modernisation-platform-environments/terraform/environments/$application.json to create infrastructure there

Proposal / Unknowns

Definition of Done

[x] Existing new account automation reviewed
[x] Propose changes needed to create new account with isolated networking
[ ] Proposal refined into issues
[ ] Document the potential risks and approach to the change

dms1981 commented 9 months ago

At present we've created data-platform-compute accounts by following our existing documentation, but only to the end of the New Environment Files steps.

The isolated networking for data-platform-compute has been created by hand through this PR.

davidkelliott commented 9 months ago

This could also be guidance for any non standard networking which members control as it's very similar steps

ASTRobinson commented 7 months ago

PR https://github.com/ministryofjustice/modernisation-platform/pull/6493 - contains the new script functional to copy to the isolated network template files located here: main/terraform/templates/modernisation-platform-environments-isolated

PR https://github.com/ministryofjustice/modernisation-platform/pull/6549 - updates our GitHub pages with details of the isolated network option and updated runbook steps for environment creation stating to only complete the New Environment Files step.

ministryofjustice / modernisation-platform