Unit Tests for Cloudtrail/Support modules in Baselines

[richgreen-moj]

User Story

As a MP Engineer I need to write some unit tests for the Cloudtrail and Support sub-modules sin the Baselines module So that I can increase the confidence in the modules

Value / Purpose

As a follow-on from https://github.com/ministryofjustice/modernisation-platform/issues/6490 this ticket is to add missing unit tests for some of the sub-modules in the MP Baselines module.

There are roughly 9 resources for unit testing.

Useful Contacts

@richgreen-moj

Additional Information

Follow-on from https://github.com/ministryofjustice/modernisation-platform/issues/6490

Proposal / Unknowns

No response

Definition of Done

• [x] Missing unit tests added
• [x] New unit tests pass
• [x] Another team member has reviewed

[ep-93]

cloudtrail ✅ - write a follow-up story to test (8 resources) https://github.com/ministryofjustice/modernisation-platform/issues/7307

support ✅ - write a follow-up story to test (1 resource) https://github.com/ministryofjustice/modernisation-platform/issues/7307

These are the resources we need to test.

[mikereiddigital]

I'm picking up this one as I've not done much with unit tests & go before. If anyone wants to pair with me on it then do shout. :)

[mikereiddigital]

Branch containing the completed support module unit test - https://github.com/ministryofjustice/modernisation-platform-terraform-baselines/tree/issue/7307. This has been tested locally against testing-test.

[sukeshreddyg]

Added unit tests for the Support and CloudTrail modules.

https://github.com/ministryofjustice/modernisation-platform-terraform-baselines/pull/547

[markgov]

just checked and the unit test is failing /home/runner/work/modernisation-platform-terraform-baselines/modernisation-platform-terraform-baselines/test/go.mod:5: unknown directive: toolchain

[mikereiddigital]

Go issue resolved with PR https://github.com/ministryofjustice/modernisation-platform-terraform-baselines/pull/551

[markgov]

All looks good