search

ministryofjustice / modernisation-platform

A place for the core work of the Modernisation Platform • This repository is defined and managed in Terraform
https://user-guide.modernisation-platform.service.justice.gov.uk
MIT License
683 stars 291 forks source link

Concurrency - Implement fix for strict sequencing of actions in scheduled-baselines when available #8215

Open mikereiddigital opened 2 days ago

mikereiddigital commented 2 days ago

User Story

As a Modernisation Platform Engineer I want all queued scheduled-baselines actions to run in the order in which they were started So that issues related to changes in a given commit or PR are not obscured by latter changes and so made more difficult to debug.

This can only be applied once github have implemented the solution as discussed here - https://github.com/orgs/community/discussions/12835#discussioncomment-10612372

Value / Purpose

The current behaviour of the concurrency feature in github actions is to cancel any waiting actions if another action of that workflow is started. The result is that subsequent action applying a larger number of changes than was originally intended and, in the event of errors, could make identifying the source of the issue take longer.

Useful Contacts

No response

Additional Information

This is an outcome of spike #6857 and the discussions that were held during its review.

This issue is also discussed here - https://github.com/orgs/community/discussions/12835#discussioncomment-10612372

Definition of Done

dms1981 commented 2 days ago

We think this should be refined once the fix is available.