fix(scss): amend sass loadpaths to include node_modules directory

ministryofjustice / moj-frontend

Use the MoJ Design System to design, build, and deliver accessible and consistent services.

https://design-patterns.service.justice.gov.uk/

MIT License

33 stars 21 forks source link

fix(scss): amend sass loadpaths to include node_modules directory #928

Open chrispymm opened 1 week ago

chrispymm commented 1 week ago

This allows us to remove the node modules prefix from the govuk scss import in all.scss. Which would resolve loading issues for users.

BREAKING CHANGE: This PR changes the loadpath for govuk frontend. You will now need to ensure your project SASS configuration includes node_modules within its loadpaths in order to compile, however this is often default behaviour in many build tools.

fix #927

starswan commented 4 days ago

Hi, there is one module that also use node_modules - cookie_banner. It would be nice to fix that one at the same time.