search

ministryofjustice / moj-frontend

Use the MoJ Design System to design, build, and deliver accessible and consistent services.
https://design-patterns.service.justice.gov.uk/
MIT License
33 stars 21 forks source link

Increase page body content on documentation site #936

Closed murrlipp closed 1 day ago

murrlipp commented 4 days ago

What

As explored in https://github.com/ministryofjustice/moj-frontend/issues/933, increasing the width of the body content on the documentation site component, page and pattern pages would allow us to represent 'full width' components at 1020px within the iframe, which is the default maximum page width recommended by GDS.

Why

We are advising that some components, such as the 'Interruption card', should be used at certain widths in services. In some cases, the width we recommend is larger than the width of the iframe on the documentation site. The component is responsively resized to fit within the iframe, but this may give users an incorrect idea of how the component should or will look in their service.

Who needs to be involved

Tasks

Done

This task is done when the change is made, reviewed, and merged into main.

murrlipp commented 1 day ago

Had a conversation with @chrispymm and agreed that this isn't necessarily the right fix, and we should instead update the interruption card to have a fixed width content wrapper so that the content never goes over 960px in width for readability.

Closing this ticket and pushing interruption card changes to the branch.