SPIKE: Evaluate potential to refactor our Terraform on Cloud Platform

ministryofjustice / operations-engineering

This repository is home to the Operations Engineering's tools and utilities for managing, monitoring, and optimising software development processes at the Ministry of Justice. • This repository is defined and managed in Terraform

https://user-guide.operations-engineering.service.justice.gov.uk/

MIT License

14 stars 5 forks source link

SPIKE: Evaluate potential to refactor our Terraform on Cloud Platform #4130

Open levgorbunov1 opened 9 months ago

levgorbunov1 commented 9 months ago

User Need

As a developer I want to better understand weaknesses of our cloud platform terraform so that it can be improved

Acceptance Criteria:

Analyse the operations-engineering Terraform on Cloud Platform for: Redundant resources/inefficient patterns and standardisation.
Create tickets to refactor the Cloud Platform Terraform.

levgorbunov1 commented 8 months ago

We should stick to IAM resource naming convention:

Resource name should be suffixed by resource type e.g. attachment, policy, or policy document.

levgorbunov1 commented 8 months ago

For simpler stacks we should separate resource relating to different AWS components into different tf files.

For more complex stacks, separation should be done by functionality groupings.

levgorbunov1 commented 8 months ago

Can make a module for state management infrastructure so we don't keep repeating ourselves.