Open andyrogers1973 opened 3 months ago
Added test_data.csv - a small csv file of test data to be used for testing.
Updated the support_stats_reporting.py script to use defaults for date/filepath in production
Fixed test file path being overridden (removed unnecessary variable from 'main') Updated 'expected message' and now works correctly Tidied up formatting and removed comments/commented out code
Removed unnecessary import and fixed pipfile.lock being out of synch, ready for review.
From PR review I have removed tests that were not needed or duplicating others. Also added tests for hash, create_dataframe_from_csv and get_previous_days_requests Removed an unneeded import (SlackService) and removed pytest + freezegun from Pipfile(hangover from testing, not being used now), re-ran pipenv lock to resync Pipfile.lock
Comments from Tamsin - made the following changes:
Currently the support stats script is not being unit tested. This means it's not conforming to coding standards and could be introducing bugs/issues.
This ticket is to create the necessary tests in the operations engineering repo:
Considered done when: