Support stats script - Unit Tests

[andyrogers1973]

Currently the support stats script is not being unit tested. This means it's not conforming to coding standards and could be introducing bugs/issues.

This ticket is to create the necessary tests in the operations engineering repo:

• write the tests and ensure the code is being tested
• highlight any bugs/issues that need to be fixed
• make sure the code conforms to our coding standards
• possible it will highlight performance issues that can be improved upon

Considered done when:

• unit tests exist and are working
• code is being fully tested
• any bugs/issues highlighted by the tests are fixed

[andyrogers1973]

4628

[andyrogers1973]

Added test_data.csv - a small csv file of test data to be used for testing.

Updated the support_stats_reporting.py script to use defaults for date/filepath in production

[andyrogers1973]

Fixed test file path being overridden (removed unnecessary variable from 'main') Updated 'expected message' and now works correctly Tidied up formatting and removed comments/commented out code

[andyrogers1973]

Removed unnecessary import and fixed pipfile.lock being out of synch, ready for review.

[andyrogers1973]

From PR review I have removed tests that were not needed or duplicating others. Also added tests for hash, create_dataframe_from_csv and get_previous_days_requests Removed an unneeded import (SlackService) and removed pytest + freezegun from Pipfile(hangover from testing, not being used now), re-ran pipenv lock to resync Pipfile.lock

[andyrogers1973]

Comments from Tamsin - made the following changes:

• renamed the hash test to make it clearer what it tests
• removed patch and mock from testgetyesterdayssupportrequests as they were not required