♻️ Refactor mass_permission_update Script - Githubissues

ministryofjustice / operations-engineering

This repository is home to the Operations Engineering's tools and utilities for managing, monitoring, and optimising software development processes at the Ministry of Justice. • This repository is defined and managed in Terraform

https://user-guide.operations-engineering.service.justice.gov.uk/

MIT License

11 stars 5 forks source link

♻️ Refactor mass_permission_update Script #4576

Closed PepperMoJ closed 1 week ago

PepperMoJ commented 1 week ago

:eyes: Purpose

To keep our codebase healthy and relevant, we aim to refactor some of the older scripts within the operations_engineering repository each sprint. This time, it was the mass_permission_update script.

:recycle: What's Changed

Functionality has been moved out of main into separate methods.
Test coverage added for the script.

:memo: Notes

No notes.

:white_check_mark: Things to Check (Optional)

[x] I have run all unit tests, and they pass.
[x] I have ensured my code follows the project's coding standards.
[x] I have checked that all new dependencies are up to date and necessary.

github-actions[bot] commented 1 week ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	flake8	2		0	0.52s
✅ PYTHON	isort	2	2	0	0.52s
✅ PYTHON	pylint	2		0	2.95s
✅ REPOSITORY	gitleaks	yes		no	1.59s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by _