ministryofjustice / operations-engineering

This repository is home to the Operations Engineering's tools and utilities for managing, monitoring, and optimising software development processes at the Ministry of Justice. • This repository is defined and managed in Terraform
https://user-guide.operations-engineering.service.justice.gov.uk/
MIT License
14 stars 5 forks source link

PARENT: Implement validation for DNS request inputs #4838

Open jasonBirchall opened 1 week ago

jasonBirchall commented 1 week ago

User Need

As an engineer,
I want to validate user input before it's used,
so that I can catch any issues at the source and reduce time spent on back-and-forth with the user.

Value

Validating the user input ensures that the data provided is correct from the start. This reduces the time spent contacting users for corrections, minimises errors in DNS changes, and improves the overall efficiency of the process.

Child Tickets

Functional Requirements (What):

Non-Functional Requirements (How):

Acceptance Criteria:

Notes:

The document linked above outlines all the form fields and corresponding validation requirements. Validators should be applied consistently to ensure that all user inputs conform to the required DNS standards.

abachleda-baca commented 5 days ago

I have implemented validation for some of the fields using Flask's message flashing functionality and the gov guidance on how to display errors. However, after reviewing the attached document I was unsure about which validation rules should be applied. It might be worthwhile to review this and agree on the input data requirements for each field.

levgorbunov1 commented 3 hours ago

This ticket is massive, spinning off children