search

ministryofjustice / security-guidance

Security guidance from the MOJ Digital & Technology Cybersecurity team
https://ministryofjustice.github.io/security-guidance/
Other
22 stars 25 forks source link

Bug on Safari 13 (iOS) #53

Closed andy-gg closed 4 years ago

andy-gg commented 4 years ago

On Safari 13, the last bullet point of each group is not clickable, including:

Note that the following links do work however:

tomdMOJ commented 4 years ago

Is this still an issue?

andy-gg commented 4 years ago

Correct - still a problem. Anyone with an iPhone with latest iOS should be able to replicate 👍🏻

warmanaMOJ commented 4 years ago

@andy-gg Hello, I've just checked using Safari on an iPhone running 13.4.1. I can't immediately see a problem - if you get a moment, please would you confirm that the problem has 'gone away'? Many thanks!

andy-gg commented 4 years ago

good morning @warmanaMOJ - (to confirm), it is still an issue on 13.3.1 but I will perform an update to 13.4.1 shortly to see if it corrects it :)

andy-gg commented 4 years ago

@warmanaMOJ - update performed to 13.4.1 - issue still exists. (for example, "Share Responsibility Models" does not open a link unlike the option above which does ("Security Log Collection"))

(To confirm, this is browsing to the following URL on Safari - https://ministryofjustice.github.io/security-guidance/)

Confirmed with @carlsixsmith this is an issue for him too on Safari and Chome (IOS)

warmanaMOJ commented 4 years ago

@andy-gg OK, thank you, yes, I see what you mean. It's interesting; the HTML appears to be well-formed, and all works fine on desktop, but not on iPhone (or indeed Chrome on Android, too). Very odd.

I'll see what i can do to fix this.

warmanaMOJ commented 4 years ago

@andy-gg I've applied a simple fix. Not exactly elegant, but it seems to work. Would you give a try, please?

andy-gg commented 4 years ago

Yeah - it's a strange one. That's working for me now though...

I wonder if instead of <p> </p>, you could just put an &nbsp in instead so the formatting doesn't change? (no worries if you tried that though!) :)

FYI - I'm also (perhaps unsurprisingly!) getting the same issue with the Technical Guidance too

warmanaMOJ commented 4 years ago

@andy-gg I'm glad the fix worked - and also, great minds think alike, the fix I tried first was to add &nbsp; like you suggested! Have a look at the changes in the index.md file.

I agree that the effect on formatting is not ideal - but it is still very usable, so I'll probably leave it as-is for the moment.

Anyway - many thanks for letting us know about the problem, thank you for your patience while we fixed it, and thank you for confirming it seems to be OK now.

andy-gg commented 4 years ago

No worries - thanks for sorting (and glad I didn't offend with my last comment - I posted without checking what you'd actually done to fix it, let alone tried before that). I kicked myself afterwards!

Do you want me to raise the issue for Technical Guidance too?

warmanaMOJ commented 4 years ago

@andy-gg No offence taken at all :-)

Yes, please, let 'em know over in technical guidance.

Thanks again.