removed unclean init of tests within make file, and made the process of starting tests cleaner.
A combination of "depends on" and the way the make file calls the tests to run.I noted when containerd was enabled. It would kill and restart the staff-device-dhcp-server-dhcp-primary-1 when it gets to this line "$(DOCKER_COMPOSE) run --rm dhcp-test rspec -f d ./spec" in the make fileSo by commenting out the depends on, it would no longer kill and restart the staff-device-dhcp-server-dhcp-primary-1 container thus not affecting the tests.
jamesgreen-moj
commented
6 months ago
removed unclean init of tests within make file, and made the process of starting tests cleaner.
A combination of "depends on" and the way the make file calls the tests to run.I noted when containerd was enabled. It would kill and restart the staff-device-dhcp-server-dhcp-primary-1 when it gets to this line "$(DOCKER_COMPOSE) run --rm dhcp-test rspec -f d ./spec" in the make fileSo by commenting out the depends on, it would no longer kill and restart the staff-device-dhcp-server-dhcp-primary-1 container thus not affecting the tests.