ministryofjustice / staff-device-shared-services-infrastructure

Staff Device AWS Infrastructure for build pipelines
https://ministryofjustice.github.io/cloud-operations/#cloud-operations
MIT License
1 stars 1 forks source link

Refactor module ci-codepipeline-webhook S3 bucket Terraform #82

Closed smjmoj closed 1 year ago

smjmoj commented 1 year ago

User Story

As an I expect to have a codebase that is compatible with the updated AWS Provider and Terraform Versions So that When running and test the code we don't have 71 warnings that

"Warning: Argument is deprecated"
Use the aws_s3_bucket_server_side_encryption_configuration resource instead
(and 71 more similar warnings elsewhere)

Value / Purpose

Keep code in a operational state.

Useful Contacts

No response

Additional Information

No response

Definition of Done

Example - [ ] Documentation has been written / updated

smjmoj commented 1 year ago

PR ready. Plan file pending WSL reboot :(

smjmoj commented 1 year ago

Code applied after some minor tweaks due to warnings given at apply stage.