search

miniupnp / miniupnp

UPnP IGD implementation
http://miniupnp.free.fr/
BSD 3-Clause "New" or "Revised" License
1.41k stars 445 forks source link

miniupnpd: UPnP IGDv2 WANIPConnection XML service description compliance #708

Closed Self-Hosting-Group closed 4 months ago

Self-Hosting-Group commented 4 months ago

The action AddAnyPortMapping of the service WANIPConnection:2 has an incorrect argument name in the XML description for the related ExternalPort state variable.

Current:

<argument>
  <name>NewExternalPort</name>
  <direction>out</direction>
  <relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>

Should be:

<argument>
  <name>NewReservedPort</name>
  <direction>out</direction>
  <relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>

See "2.5.17.1 Arguments" (AddAnyPortMapping) and "4 XML Service Description": http://upnp.org/specs/gw/UPnP-gw-WANIPConnection-v2-Service.pdf