search

miniupnp / miniupnp

UPnP IGD implementation
http://miniupnp.free.fr/
BSD 3-Clause "New" or "Revised" License
1.41k stars 445 forks source link

miniupnpd: Do not SSDP notify using global-scope (ff0e::c) IPv6 multicast #757

Open Self-Hosting-Group opened 1 week ago

Self-Hosting-Group commented 1 week ago

The global-scope multicast address is only defined in UDA 1.1 and not in UDA 1.0 Annex A - IPv6 and the UDA 2.0 specifications state that it shall not be used. UDA 1.1 defines that either global-scope (ff0e::c) or site-local scope (ff05::c) can be used, but global is preferred in complex topologies. As the site-local scope is defined in all versions of UDA, the daemon should probably only use it.

Currently the daemon already behaves in this way, but only if UPNP_STRICT is defined. See this:

https://github.com/miniupnp/miniupnp/blob/c735d2b39a7931de0c9ec1b59a3ffa0de4366536/miniupnpd/minissdp.c#L748-L752

Self-Hosting-Group commented 1 week ago

How about an IPv6 GH label?

miniupnp commented 1 week ago

I don't understand the problem here.

what do you mean by IPv6 GH label ?

Self-Hosting-Group commented 1 week ago

what do you mean by IPv6 GH label ?

IPv6 GitHub label (to organise issues/PRs)

miniupnp commented 1 week ago

ah ok

miniupnp commented 1 week ago

So what's the issue here ?