minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
71 stars 49 forks source link

Player coloring not working for derby matches #1

Closed minj closed 9 years ago

minj commented 9 years ago

Original issue 1 created by larsts on 2008-04-06T16:19:12.000Z:

What steps will reproduce the problem?

  1. Check a derby match, example matchid 162909227 (https://www.hattrick.org/goto.ashx?path=/Common/MatchDetails.aspx%3FmatchID%3D162909227%26amp%3BuseArchive%3DTrue)

What is the expected output? What do you see instead? Should see player coloring, no coloring is added.

What version of the product are you using? On what operating system? Foxtrick 0.3.64, FF 2.0.0.13, Windows XP.

Please provide any additional information below.

For derby matches, Hattrick now adds a link to the region the teams are in. From the example: People from all over Oslo had joined up for the derby.

Extraction of the variables TeamA and TeamB in matchDetailPlayerColoring() fails with the extra region nodes in the DOM.

minj commented 9 years ago

Comment #1 originally posted by kolmis on 2008-05-20T12:46:56.000Z:

fixed in 61a6eaa145221212b43e7f9e57d8c10038ce8f1f r53 61a6eaa145221212b43e7f9e57d8c10038ce8f1f r53

Status: Fixed