Update event icons in MatchReportFormat

[minj]

From: llramone_nonumber PostID: 16751289.23 To: Everyone Re: 16751289.1 Datetime: 2015-03-19 10:51 Message:

I cant see the Reorganize and Nerveous icons at Match Report, check minutes 90 and 83 on this match (5924940) Cache cleared, all the others icons are working fine, should I do something else?

Thanks!

---

FoxTrick 0.14.0.3 release mozilla - Stage: false - Skin: normal - en - ltr - 1280 x 773 - Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:36.0) Gecko/20100101 Firefox/36.0 - MacIntel

[minj]

current icons: https://github.com/minj/foxtrick/tree/master/content/resources/img/matches

[minj]

Event descriptions Icon definitions Event<->icon map

[ratsrats]

I sure like to support Foxtrick. Give me some time, I'll look in to the subject : )

[ratsrats]

"There are quite a few match events that could benefit from additional icons."

I could not make up for which match events new icons are to be made. From browsing the list img/matches, there appear to be a lot of different sizes for icons.

1. Could you supply me with a list of events that need an icon?
2. What are minimal and maximum measurements for the icons?

[minj]

    22: 'Incomplete lineup, players from neighborhood used',
    25: 'Regional derby',
    26: 'Neutral ground',
    27: 'Away is actually home',
    30: 'Spectators/venue - rain',
    31: 'Spectators/venue - cloudy',
    32: 'Spectators/venue - fair weather',
    33: 'Spectators/venue - sunny',
    45: 'Half time results',
    46: 'Hat-trick',
    60: 'Underestimation',
    63: 'Remove underestimation on break',
    64: 'Reorganize',
    66: 'Decrease underestimation on break (equal score)',
    67: 'Decrease underestimation on break (up by 1 goal)',
    69: 'Remove underestimation',
    72: 'Extra time decided',
    80: 'New captain',
    81: 'New set pieces taker',
    331: 'Tactic Type: Pressing',
    332: 'Tactic Type: Counter-attacks',
    333: 'Tactic Type: Attack in the middle',
    334: 'Tactic Type: Attack on wings',
    335: 'Tactic Type: Play creatively',
    336: 'Tactic Type: Long shots',
    343: 'Tactic: Attack in the middle used',
    344: 'Tactic: Attack on wings used',
    500: 'Both teams walkover',
    501: 'Home team walkover',
    502: 'Away team walkover',
    503: 'Both teams break game (2 players remaining)',
    504: 'Home team breaks game (2 players remaining)',
    505: 'Away team breaks game (2 players remaining)',
    700: 'Event-o-Matic: Taunt Opponent',
    701: 'Event-o-Matic: Praise Opponent',
    702: 'Event-o-Matic: Plead for Fan Support',
    703: 'Event-o-Matic: Build Positive Atmosphere',
    704: 'Event-o-Matic: Honour Club Legacy',

These are missing. I'm not sure each and every one of them needs an icon though. I'll leave that to your discretion. Any addition is good obviously.

As for the sizes: there are no standards there as usual :D I see 12x12, 14x14, 16x16, even 19x16. I'd say we should be going for 16x16. Or 20x16 if you need a wider icon.

[ratsrats]

Browsing through offered lists I encountered:

bruised: '/Img/Icons/bruised.gif',

I was not able to find this icon. There is an icon folder, in lower case. The uppercase Icon folder is not visible to me. I would like to see some icons before continuing.

The 'tacticType' icons will be the first to take on.

[minj]

FT icons are only where you see Foxtrick.resourcePath. Otherwise we reuse HT icons: https://www.hattrick.org/Img/Icons/bruised.gif ;)

2015-05-11 12:55 GMT+03:00, ratsrats notifications@github.com:

Browsing through offered lists I encountered:

bruised: '/Img/Icons/bruised.gif',

I was not able to find this icon. There is an icon folder, in lower case. The uppercase Icon folder is not visible to me. I would like to see some icons before continuing.

The 'tacticType' icons will be the first to take on.

---

Reply to this email directly or view it on GitHub: https://github.com/minj/foxtrick/issues/1286#issuecomment-100841070

[ratsrats]

These are the first suggestions.

[ratsrats]

Suggestions for: aim aim used aow aow used

[minj]

Are you sure they need to be different? I'd prefer the ones corresponding to 'used' for both cases

[ratsrats]

That's all right ; )

[ratsrats]

here are some more:

icon play creatively icon counter attack

[ratsrats]

here are some more:

icon counter attack 2 icon longshot

[ratsrats]

here are some more:

icons pressing 20 and 30 px.

[ratsrats]

her is an other one:

icon play creatively 2

[ratsrats]

here is an other one:

icon pressing 3

[minj]

It's a bit unclear to me what these are supposed to symbolize:

as for the muscle, I think it would be clearer if it was rotated ~90deg CW

[ratsrats]

Before playing CA, you have to build a wall, to stop the attack : ) In Germany, building a wall or producing concrete is synonym for building a strong defense. In England one defender is called Ronny Concrete for the same reason.

pressing 5

[minj]

I wanted to nudge you a bit :smile:

I would prefer to have these icons for next version since this requires no code changes and should be failproof.

E. g. icons are definitely needed for events that effect ratings (like underestimation)

[minj]

@ratsrats If you don't have the time, just say so. It's fine.

[ratsrats]

@minj you must have fallen of the radar.

[ratsrats]

Would you be so kind to produce a list of icons that are due:

underestimation . .

size will be: 20x20 px

[minj]

I think these are most important:

25: 'Regional derby',
26: 'Neutral ground',
60: 'Underestimation',
63: 'Remove underestimation on break',
64: 'Reorganize',
66: 'Decrease underestimation on break (equal score)',
67: 'Decrease underestimation on break (up by 1 goal)',
69: 'Remove underestimation',

Those remove/decrease underestimation could be the same icon obviously

[ratsrats]

I will have a go at these.

[ratsrats]

[ratsrats]

from top to bottom:

reorganise decrease underestimation remove underestimation underestimation neutral ground regional derby

[minj]

Cool thanks, I'll include them in new release soon. I'll also add you to our contributor list as a designer

[ratsrats]

thank you, the pleasure is all mine.