Make missing icons for new cup types in CustomMedals

[minj]

We need at least 4 icons for CupB1, CupB2, CupB3, CupC. CupA could be re-purposed from the old cup icon, I guess.

---

From: kopsterkespits PostID: 16412248.359 To: Everyone Re: 16412248.358 Datetime: 2015-03-22 11:20 Message:

I have old medals thicked because I like them way better than the ugly 'new' ones. But... after 10 years of struggeling I finally won a price but it's not displayed in my price shelve. Is there a way to fix this or can someone make 'new old medals' please?

In case someone does I think the secondary cups should be smaller.

---

From: kopsterkespits PostID: 16412248.365 To: LA-MJ Re: 16412248.364 Datetime: 2015-03-28 11:43 Message:

(211465) this team has the normal cupmedal. Mine has the new one, lol blank atm...

I did try to 'green up' a secondary cup and make it a bit smaller.

(http://i57.tinypic.com/2h4hs0g.gif)

is this useful?

I don't get it right now if they can be replaced or not btw.

---

FoxTrick 0.14.0.3 release mozilla - Stage: false - Skin: normal - nl - ltr - 1920 x 1040 - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 - Win32

[minj]

For testing: OLD: (211465) NEW: (145644)

[ratsrats]

"We need at least 4 icons for CupB1, CupB2, CupB3, CupC."

Here are some proposals:

[minj]

@ratsrats I think you missed the point... They should look like old medals, not new :)

[ratsrats]

Forum » FoxTrick » Developer Murkos [post=16281487.387] displayed as first cup:

Old-type cup in season 32: (/AppThemes/Standard/images/trophies/leaguecup...)

I took that one as a starting point. "Old-type cup" could hardly be interpreted as "new". Could someone please get the confusion out of the way and explain - with an example - where to start from.

[minj]

The ones you see in that message are made by HTs and you can see them with or without Foxtrick. They are 'new-style' trophies.

Foxtrick module CustomMedals brings back the 'old-style' trophies. E.g. trophy list for (211465) looks like this:

Now, 'new' cups(=tournament type) refer to the new cup system. Cup was changed into CupA, and cups B1,B2,B3,C were added. Each of them got a new-style trophy icon.

The problem is we don't have 'old-style' trophies for new cups.

[minj]

You can the 'old-style' trophies we already have here: https://github.com/minj/foxtrick/tree/master/content/resources/img/custommedals/oldhtmedals

[ratsrats]

So the old league cup = cupA which remains as is, equals the first cup from your example. cups B1-2-3 and C are to be designed, to accomdate user requests, in style of the old league cup, cupA now.

[minj]

precisely

2015-04-17 16:20 GMT+03:00, ratsrats notifications@github.com:

So the old league cup = cupA which remains as is, equals the first cup from your example. cups B1-2-3 and C are to be designed, to accomdate user requests, in style of the old league cup, cupA now.

---

Reply to this email directly or view it on GitHub: https://github.com/minj/foxtrick/issues/1290#issuecomment-93984606

[ratsrats]

Here is a cupB1 proposal

[ratsrats]

The width - 34 px - is adapted to the width of the new ones, as is the color.

B2 will be with one ear, in red, B3 will be with no ears, in blue, C1 will have no ears and no lid.

[minj]

Looks good I think. I don't know about the size though. It seems to me they should not be larger than cupA (ex cup). Unless you would like to redo that one as well ;)

2015-04-17 21:01 GMT+03:00, ratsrats notifications@github.com:

The width - 34 px - is adapted to the width of the new ones, as is the color.

B2 will be with one ear, in red, B3 will be with no ears, in blue, C1 will have no ears and no lid.

---

Reply to this email directly or view it on GitHub: https://github.com/minj/foxtrick/issues/1290#issuecomment-94040273

[ratsrats]

You are right about the size. The cupA sould be 34 px wide as well.

The old widths are extreme small; @ 34 px the cups have a bit more 'breathing' room. That way they will fit better in the website layout.

[ratsrats]

Here follows a missing cup proposal

[ratsrats]

From top to bottom: cupA, cupB1, cupB2, cupB3, cupC Width is 34 px, colors, chosen from the new cups.

It could be a no-issue: I do not have copyrights to these images. If you think it would be necessary, you should give it more attention.

You could still be choosing the old cup @ 34px ; )

[minj]

Looks like you have a universal seal of approval :)

[jetwitaussi]

great!

[ratsrats]

Please replace cupB2 with following, a couple of px got lost in the last one.

[ratsrats]

It has been my pleasure!

[minj]

The problem with that module is that it is hard-coded for 30x30 gifs. While using gifs is not that bad in this case I guess (quite a size benefit in truth) I would need to rewrite it slightly for custom image sizes.

Anyway here's how it would look:

Personally I don't have an opinion either way but some could find the size difference disturbing. Down-scaling to 30px would also make my life easier ;)

[ratsrats]

No problem, if you prefer the 30 px gifs, I'll produce those.

The cup is a sweet design. I never liked the shields though, they look more like weard ducks ; ) , hardly to distinguish one from another.

[ratsrats]

An other option, to do things right, would be to enlarge the shields as well to 34 px wide. That way all medals would fit better into the HT page lay-out.

@minj If you decide to code for 34 px wide, I will supply you with the resized shields.

[minj]

@ratsrats sorry for taking the time to respond. I was working on Links modules. I also tried to elicit some feedback from HT forums but few people care it seems :)

Somebody commented that the cups look a bit pixelated and I agree. I think it's best to do them as 30x30. Do you have hires versions that you could scale down or should I just do it myself?

[minj]

Here's how it looks:

[ratsrats]

When you are happy, we all are happy ; )

The pixelation comes from the enlarging from 30 --> 34 px. There is no hires, it all starts with the 30 px wide icons.

[minj]

@ratsrats if you still feel like helping out, please take a look at #1286 next. There are quite a few match events that could benefit from additional icons.

[minj]

It seems I was a bit optimistic with this. There are a bunch more different trophies HTs use.

trophyCupDivisional7A: trophyCupDivisional8A: trophyCupDivisional9A: trophyCupDivisionalB1: trophyCupDivisionalB2: trophyCupDivisionalB3:

trophySupporterWeekTrophyWinner: trophyTournamentWinner1: trophyTournamentWinner2: trophyTournamentWinner3:

tutorialResult1: tutorialResult2: tutorialResult3: tutorialResult4:

[ratsrats]

So, 11 new cups old style are requested and 3 tutorial results. I'll think of something appropriate ; )

[minj]

I don't actually know where, how and why tutorialResult* are used, if we can actually see them and if they really need to be made. I just found them on HT list...

[ratsrats]

where can I find the CupA, B1, B2, B3 C cups as modified by yourself?

[minj]

same as previously: https://github.com/minj/foxtrick/tree/master/content/resources/img/custommedals/oldhtmedals

[ratsrats]

Here follows a missing cup proposal:

[minj]

@ratsrats sorry for not getting back to you for so long. I wanted to get some opinions first and since so few people visit github I always cross-post stuff like that in HT forums. Even though I tried to encourage discussion on HT forums a couple of time there were few taker, however.

The show must go on, though, so I channel my time where I am needed most/am best at. As you may be aware I had to make new infrastructure to adhere to Mozilla's addon signing policy. Additionally HTs constantly make new changes that break things all the time but everybody and their gradma just want everything working smoothly as well as their new ideas implemented ASAP.

TL;DR maintaining Foxtrick alone is hard.

---

Now as for your cup proposals, people did not particularly like the numbering system. I am not specifically against it but I think a more pleasingly-looking font would be nice.

However, the B cups don't look right. I think the whole system needs a bit of tweak. I have some ideas if you can spare more of your time and talent :)

[minj]

TODO:

• [x] main B* cups need to look the same, different colors only. This should probably be intermediate type (=currently red).
• [x] lower league B cups need to also look the same, different colors only. This should probably be low type (=currently blue).
• [ ] lower league A cups need to look the same as B cups above, only purple + roman numeral
• [ ] trophy cups need new designs

[ratsrats]

Hi, I'm completely caught by surprise ; ) missed your 6 oct post. Forgot all about it. So what is it all about? About cups ; )

When you could provide me with superfluous detailed information in pictures, I'll be happy to be of assistance. .

[minj]

Welcome back @ratsrats :+1:

Well the TODO list pretty much covers it:

• trophyCupB* cups are of the same rank and need to look the same, only different colors (red, green, blue). I think they should all have one 'ear' like the red one above so blue & green should be remade.
• trophyCupDivisionalB* cups should also be of the same (but lower rank) and I think they should have no ears but with one pom pom like the blue one above so green & red should be done accordingly.
• trophyCupDivisional*A should look like trophyCupDivisionalB* but purple and with roman numerals like HT originals up above.
• need some new ideas for trophySupporterWeekTrophyWinner and trophyTournamentWinner*

[ratsrats]

I haven't forgotten.

Please be patient : )

[ratsrats]

Some ideas are waiting to be developed, please hang on.

[ratsrats]

Some samples, from the net. The medals come in 7 varieties in gold silver and bronze. Is it something we are looking for?

[minj]

not sure..

perhaps the first one for trophyCupDivisional*A (with roman numerals), last 3 for trophyTournamentWinner*, and the other 3 for trophyCupDivisionalB*

in any case they have a different style and need to be adapted somehow

[ratsrats]

adapted, looking for improvement.

[ratsrats]

added contrast this one

[ratsrats]

to see these together

[ratsrats]

These were mend to be different. May be we should look further?

[ratsrats]

with roman numerals, the same medal in 2 versions.

[minj]

I like on the whole but isn't it too different from the old ones? Perhaps something like that would suit trophySupporterWeekTrophyWinner instead.

You don't like my ideas in the TODO list?

[ratsrats]

I like almost all your ideas : )

That is not the point. You have to educate me . . . I wouldn't know how a trophySupporterWeekTrophyWinner would look like. Now I have looked again into this thread. The August 9th post . . . ; )

I'll try and bring it all closer together.

[ratsrats]

Recap:

Well the TODO list pretty much covers it:

trophyCupB* cups are of the same rank and need to look the same, only different colors (red, green, blue). I think they should all have one 'ear' like the red one above so blue & green should be remade.

trophyCupDivisionalB* cups should also be of the same (but lower rank) and I think they should have no ears but with one pom pom like the blue one above so green & red should be done accordingly. trophyCupDivisionalA should look like trophyCupDivisionalB but purple and with roman numerals like HT originals up above. need some new ideas for trophySupporterWeekTrophyWinner and trophyTournamentWinner*

Is this correct?

[ratsrats]

It takes a lot of time, before I can see what you mean. I had thought the already delivered cups were ready. But it seems you want to use those, with some tweaking. and you need something new for trophySupporterWeekTrophyWinner and trophyTournamentWinner*

[ratsrats]

Here is my proposal:

trophySupporterWeekTrophyWinner

trophyTournamentWinner*

[ratsrats]

Here is my proposal

trophyCupDivisionalB* cups