minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
69 stars 49 forks source link

Duplicated Forum notifications in Firefox #1614

Open minj opened 5 years ago

minj commented 5 years ago

From: Synthespian PostID: 16896702.788 To: LA-MJ Re: 16896702.787 Datetime: 2018-11-21 15:13 Message:

I've noticed with the beta in firefox that when i get a forum reply to me it (pop-up) notifies me to say I've got a new "message".

I've even seen it do the forum notification as well, so I get two notifications for the price of one. ;)

minj commented 5 years ago

From: murko PostID: 16896702.789 To: Synthespian Re: 16896702.788 Datetime: 2018-11-22 10:08 Message:

Synthespian rašė:

I've noticed with the beta in firefox that when i get a forum reply to me it (pop-up) notifies me to say I've got a new "message".

I've even seen it do the forum notification as well, so I get two notifications for the price of one. ;)


I think it actually says (the notification at least) that you got a new mail. The very same notification you get when actually recieving a HT-mail. I on the other hand don't get two of these so I didn't quite understand the 2 for 1 pun :)

But it really should say "forum-reply" in the case of that and not mail.

(https://i.snag.gy/UMQSls.jpg)

These are my settings on that module (same module, but the text should present it self different according to of it's a mail or a forum -reply I guess. - in the notification that is)

The notification pop-up I get is Foxtricks one in the bottom right hand corner

minj commented 5 years ago

From: murko PostID: 16896702.801 To: Synthespian Re: 16896702.799 Datetime: 2018-11-22 22:55 Message:

Now I got the two as well.

module=NewMail

I have checked 2 of 4 (not the sound ones)

module=TickerAlert

If I check Forum replies in that one I think that also gives a notification

I think it's this one showing the correct text actually (showing name of thread) on notification pop-up

So I'm guessing you have this checked as well?

Maybe try to ONLY have this one checked and uncheck the forum part in the module NewMail?

Edit: In "conclusion"

I think the module NewMail reads info from the yellow circle (when there is a number behind the text "forum") and the module TickerAlert reads info from the blue circle whenever there is a new bolded message there.

That's why we get two maybe?

(https://screenshotscdn.firefoxusercontent.com...9.png)


Foxtrick 0.17.9.1112 beta-2b84c1860 webext - Stage: false - Skin: normal - sv-SE - ltr - 1680 x 1020 - Mozilla/5.0 (Windows NT 10.0; rv:63.0) Gecko/20100101 Firefox/63.0 - Win32

minj commented 5 years ago

From: Synthespian PostID: 16896702.802 To: murko Re: 16896702.801 Datetime: 2018-11-22 23:09 Message:

murko rašė:

module=NewMail

I have checked 2 of 4 (not the sound ones) Agreed.

I have these two checked.

module=TickerAlert

If I check Forum replies in that one I think that also gives a notification

I think it's this one showing the correct text actually (showing name of thread) on notification pop-up

So I'm guessing you have this checked as well?

Yes.

Matbe try to ONLY have this one checked and uncheck the forum part in the module NewMail? Disabled. Ready to play.

minj commented 4 years ago

image