search

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
69 stars 49 forks source link

Wrong U21 World Cup/Continental Cup Eligibility #1660

Closed Gundor closed 2 years ago

Gundor commented 4 years ago

There has been an update of U21 competitions, with introduction of Continental Cup.

An example : https://i.imgur.com/RT5RQFK.png

minj commented 4 years ago

@rferromoreno wanna take it?

rferromoreno commented 4 years ago

@minj yes Sir!

I already worked on it. I only have to put it into Foxtrick code. Going to do it ASAP. Just wanting to mantain keep code for old World CUp format as well.

minj commented 4 years ago

Don't forget to fetch first. I had merged huge changes recently

minj commented 4 years ago

@rferromoreno ping?

Gundor commented 4 years ago

an update would be really welcome, because the new generation of player is coming and can play the new Regional Cup

FloJ12 commented 2 years ago

The Text U21 is now okay, but the eligibility round is still not correct. For example: Florian Brandl (296675160) should be eligible until Finals, but Foxtrick says he can play until Semifinals

rferromoreno commented 2 years ago

The Text U21 is now okay, but the eligibility round is still not correct. For example: Florian Brandl (296675160) should be eligible until Finals, but Foxtrick says he can play until Semifinals

Nice catch. I think there are actually 3 defects. One with the player days offset, other one with the CC match #4 (its not taken into account), and the last one between semifinals and finals

I need to check if this match day schedule was always this way

rferromoreno commented 2 years ago

The Text U21 is now okay, but the eligibility round is still not correct. For example: Florian Brandl (296675160) should be eligible until Finals, but Foxtrick says he can play until Semifinals

Ok, adding more info here. I can confirm that initially the calendar was another, so I will need to recreate the offets for the matches. This was the initial schedule, but it seems it changed when they started in order to do the Live Draw.

rferromoreno commented 2 years ago

@FloJ12 I already created the PR here and tested the case with your player. But if you have more players to test please go ahead, you can clone my branch into your local.