search

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
72 stars 49 forks source link

Integrate Mercattrick statistics on transfers list page (skills table and player box) #1665

Closed dromichet closed 4 years ago

dromichet commented 4 years ago

Resolves minj/foxtrick#1656

minj commented 4 years ago

Sorry for the delay. I hope to have time for FT next week

dromichet commented 4 years ago

No problem! I was just curious if the implementation is ok or do I need to change anything.

minj commented 4 years ago

I've looked through the code and can't see any major issues for now. Detail review will follow later.

I see that you've added CORS headers, that's a nice workaround until I get the hold on myself and reimplement the permission system :)

minj commented 4 years ago

Apologies for the delay. I was not in a good place mentally for weeks.

dromichet commented 4 years ago

Hi @minj. I'm sad to hear that, but I hope everything is fine now!

Regarding your review, since I'm not very sure about all the changes that I need to do, I've sent you an access invitation to my repo. I don't know if I need to grant you any other rights, so let me know.

minj commented 4 years ago

Thanks for your contribution

dromichet commented 4 years ago

I was just about to finish the remaining issues when I noticed you already merged it. Thanks @minj.

minj commented 4 years ago

@dromichet you've forgot MercattrickStats.title l10n string ;)