search

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
69 stars 49 forks source link

MaxTools #1667

Open kauefelipe opened 3 years ago

kauefelipe commented 3 years ago

Module to show last match U20/U21/Senior

minj commented 3 years ago

I don't really like that this module is using an external API. This is not a ML model and can be calculated internally

MaxDareDevil commented 3 years ago

I don't really like that this module is using an external API. This is not a ML model and can be calculated internally

Hi @minj. The idea to use an API is to avoid duplicate the code for perfect age. The next U21 world cup is really complex and a given player may have two perfect age use. In the future me and @kauefelipe would like to extend the integration between Foxtrick and MaxTools always using APIs. For example allowing at match's order page review a direct result estimation using https://ht-mt.org/match/result-estimation. We would like to extend the perfect age information adding not only "last match" but also "last complete phase" and informing the amount of training the player would accumulate less than one in real perfect age for the phase. So if we keep only one code that will be really interesting to avoid rework. This is the reason for the API approach.

kauefelipe commented 3 years ago

Hi @minj.

Good afternoon. Did you see MaxDareDevil's justification for using an API? You could see the plugin code? It would be nice to have a solution since the old U20 that is on foxtrick is showing the wrong dates.

MaxDareDevil commented 3 years ago

Hi, I just renamed the account name here to be the same used at HT.

minj commented 3 years ago

Apologies for the delay. I was not in a good place mentally for weeks.

MaxDareDevil commented 3 years ago

Apologies for the delay. I was not in a good place mentally for weeks. Please do not worry about that. I'm in hurry with RL issues as well. I will talk with @kauefelipe asap.

minj commented 3 years ago

You could see the plugin code?

@kauefelipe I am not exactly sure, what you've meant here.

Btw, I'll ask for a CHPP feature to confirm this integration

minj commented 3 years ago

Are you still interested in working on this?

I would specifically like to see these:

kauefelipe commented 3 years ago

Hello minj. I was on vacation last month and I couldn't get anything because I spent a lot of time traveling. I will try to make adjustments in the next few days.

kauefelipe commented 3 years ago

@minj , I made some of the adjustments you asked for.

I'm new to Git and I'm still learning. I gave you permission in my repository if you want to make any adjustments directly.

minj commented 3 years ago

Alright I hope to look at it this week but I can't make promises