Restrict the width of the player info table on the player detail page

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.

https://www.foxtrick.org

GNU General Public License v3.0

71 stars 49 forks source link

Restrict the width of the player info table on the player detail page #1696

Open smismib opened 1 year ago

smismib commented 1 year ago

Texts are too long if wage options are enabled, causing the problem in the div on its right in certain languages (Chinese and Japanese at least as far as I know).

Restrict the width of player info table on player detail page if the skills are visible under the new design.

Current Chinese version behaviour current

After the fix fix

Current English verison english_current

English version after the fix english_fix

minj commented 1 year ago

Thank you for your PR but I do not think this is ready to be merged as is.

Are you sure this is not caused by either of the following?:

RTL CSS problem
Parsing failure (I see "undefined" in the screenshot)

I do not agree with your solution of adjusting CSS in a random util function.

My suspicion is this needs to live next to the wage feature.

Please take a look at Foxtrick.Pages.Player.getWage referenced by ExtendedPlayerDetails module. It's likely where the problem actually lies.

smismib commented 1 year ago

RTL CSS problem My language is not RTL. I haven't looked at the code RTL support. I am not sure how RTL could potentially affect this.
Parsing failure (I see "undefined" in the screenshot) The parsing failure always shows up for me. I can take a look, find out what goes wrong, and make a fix if possible.

The problem is regarding the width of the section. Wage is one part of it. The other part which may make it too wide is a row called "U21 World Cup Eligibility". See the screenshot (and it's without the parsing error)

May I have your suggestion on this since changing things in Wage alone won't let us get rid of the problem?