search

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
69 stars 48 forks source link

In players.js, use nationalplayers 1.5 rather than the default 1.2 - display specialities on match line-up #1700

Closed dominiquelee closed 1 year ago

dominiquelee commented 1 year ago

1.5 brings the players' specialties in the XML, which makes displaying them in MatchLineupTweaks possible. This may not work correctly during fog of war stage.

1.3 to 1.5 also bring changes to supporter-related fields and add avatar and player cards fields, which may have an unexpected impact.

I have only tested this change through enforcing the version using developer tools breakpoints in the browser, and have not played with unpacked extension debugging. I have only checked the impact on the match line-up page, not elsewhere.

See specialties being displayed: image

dominiquelee commented 1 year ago

Also, Contributing.md (https://github.com/minj/foxtrick/blob/b7c1f6d164cae2f3bc1cb8fa54776794c655d4a4/.github/CONTRIBUTING.md#workflow) and Hacking.md (https://github.com/minj/foxtrick/blob/b7c1f6d164cae2f3bc1cb8fa54776794c655d4a4/.github/CONTRIBUTING.md#workflow) have different guidelines regarding the target branch of small fixes, so I might not be targeting the right one in this PR.

minj commented 1 year ago

lgtm, thank you

minj commented 1 year ago

@dominiquelee to answer your question, the right branch is now master, the other guidelines may be obsolete