minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
71 stars 49 forks source link

forummovelinks.js => cfUserInfo is undefined at Line 56 #32

Closed minj closed 9 years ago

minj commented 9 years ago

Original issue 32 created by spambot.de on 2008-12-16T03:00:21.000Z:

Error: cfUserInfo is undefined chrome://foxtrick/content/forum/forummovelinks.js Line 56

What steps will reproduce the problem?

  1. Open a thread

What version of the product are you using? On what operating system? no supporter reduced skin

minj commented 9 years ago

Comment #1 originally posted by larswortel on 2008-12-16T08:07:50.000Z:

Should have known it wouldn't work for non-supporters. I don't know why without seeing the HTML code though, so could you upload the source code of one of the forum pages? Preferably one in a thread I can see as well, such as this random one from Global: https://www.hattrick.org/goto.ashx?path=/Forum/Read.aspx%3Ft%3D12269894%26v%3D4%26n%3D1

(replace the 88 with the server number you're logged in on).

Status: Accepted

minj commented 9 years ago

Comment #2 originally posted by spambot.de on 2008-12-16T10:32:54.000Z:

Hope it is enough source. :)

minj commented 9 years ago

Comment #3 originally posted by larswortel on 2008-12-16T10:40:01.000Z:

You don't have avatars switched on, in which case this indeed doesn't work and cannot work. I'll make two changes: 1) Make a clear note that you should have the 'Show avatars' option switched on in Hattrick 2) Write a small change so that you won't get an error when you don't have avatars switched on (in fact, so that Foxtrick won't even try to execute the MoveLinks function)

Could you perhaps switch the 'Show avatars' function on in Hattrick? Or is that Supporter-only? If you can switch it on, it would be good to know if it does work then.

minj commented 9 years ago

Comment #4 originally posted by spambot.de on 2008-12-16T10:53:36.000Z:

If i switch avatars on @ Forums it works fine, but only on the replied post.

minj commented 9 years ago

Comment #5 originally posted by spambot.de on 2008-12-16T13:11:24.000Z:

Another Bug: All flags and league-links were not shown after a reply of the user (not always).

Also the flag&league-links are placed wrong for non-supporters.

minj commented 9 years ago

Comment #6 originally posted by larswortel on 2008-12-16T13:19:10.000Z:

Can you send me the source codes again of those two pages? Also I'd like to know the thread id's if at all possible.

minj commented 9 years ago

Comment #7 originally posted by spambot.de on 2008-12-16T13:27:09.000Z:

Sources.

minj commented 9 years ago

Comment #8 originally posted by larswortel on 2008-12-16T13:54:47.000Z:

Possibly fixed in the new rev. Awaiting feedback, especially a screenshot would be helpful in this case.

minj commented 9 years ago

Comment #9 originally posted by spambot.de on 2008-12-16T14:01:38.000Z:

It's still the same.

minj commented 9 years ago

Comment #10 originally posted by larswortel on 2008-12-16T16:22:21.000Z:

Issue finally resolved! :)

Status: Fixed

minj commented 9 years ago

Comment #11 originally posted by spambot.de on 2008-12-18T10:31:40.000Z:

Problems with reduced skin: 1) Icon transparency needed 2) some pixel can be saved 3) more pixel for the message available 4) maybe replace the string to "=>" so the posting header isn't wrapped

minj commented 9 years ago

Comment #12 originally posted by larswortel on 2008-12-18T10:42:13.000Z:

Thanks for the comments!

1 and 2) Will look into it 3) If the MoveLinks feature is disabled, it's not necessary to have the 'Show avatars' function in HT switched on. Switching that off will remove that empty space as well. If you switch on MoveLinks (and have also switched on Foxtricks HideManagerAvatar function), Foxtrick will remove the empty space for you. 4) Sounds like a good suggestion.

minj commented 9 years ago

Comment #13 originally posted by spambot.de on 2008-12-18T10:59:37.000Z:

to point 3) If you switch on MoveLinks (and have also switched on Foxtricks HideManagerAvatar function), Foxtrick will remove the empty space for you.

=> Forum preferences: Show avatars but Foxtrick does not remove the space

minj commented 9 years ago

Comment #14 originally posted by larswortel on 2008-12-18T11:08:35.000Z:

Right you are, there was a small bug in de code (copypaste-error, really). Fixed in 3fd450ac2caa2ea4c76d3d2f8a062732ea129c54 r216.

minj commented 9 years ago

Comment #15 originally posted by larswortel on 2008-12-19T14:54:13.000Z:

Implemented point 4) now as well, but only if Alltid flags are switched on (otherwise it isn't necessary).