minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
71 stars 49 forks source link

Player Filters gets buggy if... #360

Closed minj closed 9 years ago

minj commented 9 years ago

Original issue 360 created by warheart_8 on 2009-03-03T06:12:02.000Z:

If you have selected "Category" from selectbox to display players. This example post gets with player filters like this:

http://img5.imageshack.us/img5/5295/aasasamk.jpg

minj commented 9 years ago

Comment #1 originally posted by convincedd on 2009-03-03T10:17:28.000Z:

generally with issues for supporters having a page source code would be helpful

minj commented 9 years ago

Comment #2 originally posted by convincedd on 2009-03-03T11:12:27.000Z:

maybe fixed: 30f2eaee82895488ad31a8b58a8af3acfc45a2ef r1904

minj commented 9 years ago

Comment #3 originally posted by warheart_8 on 2009-03-03T12:51:33.000Z:

yep. this works now with categories too.

minj commented 9 years ago

Comment #4 originally posted by convincedd on 2009-03-03T13:19:13.000Z:

good. catagories are supposed to stay for normal filters and only don't show for pictures. works too? it's fine for you like that?

minj commented 9 years ago

Comment #5 originally posted by warheart_8 on 2009-03-03T15:11:45.000Z:

I dont know what happened but its not working anymore.

here is page source code, but I didnt change the file, tell me if anthing wrong.

minj commented 9 years ago

Comment #6 originally posted by warheart_8 on 2009-03-03T15:20:22.000Z:

here is better sourcecode (without foxtrick)

minj commented 9 years ago

Comment #7 originally posted by convincedd on 2009-03-03T20:45:05.000Z:

i'd need one with kategories on. there are non in that source code.

minj commented 9 years ago

Comment #8 originally posted by warheart_8 on 2009-03-03T20:52:52.000Z:

maybe this is better?

minj commented 9 years ago

Comment #9 originally posted by warheart_8 on 2009-03-03T21:02:08.000Z:

or this..

minj commented 9 years ago

Comment #10 originally posted by convincedd on 2009-03-03T21:14:55.000Z:

d04d23704b2246766d98a230743cc9b3ebd23d05 r1916

minj commented 9 years ago

Comment #11 originally posted by warheart_8 on 2009-03-03T21:20:04.000Z:

still dont work.. baumanss quick fix; Quick fix: h2.category {display:none !important;}

minj commented 9 years ago

Comment #12 originally posted by convincedd on 2009-03-03T21:26:49.000Z:

its a quick fix, not a proper fix :)

i'd like to have categories displayed when filtering eg cards, but only none empty categories. the quick fix can't do that. it just doesn't show any categories when useing filters.

minj commented 9 years ago

Comment #13 originally posted by warheart_8 on 2009-03-03T21:31:04.000Z:

oK. So you want to have categories to be displayed on player filters when you have selected it from selectbox? Nah, this works then. I have players in right category, but there are still some extra categories.

minj commented 9 years ago

Comment #14 originally posted by warheart_8 on 2009-03-03T21:33:40.000Z:

all categories should be away from pictures, and from the filter which dont have example midfielders, but there is still categories for midfielders, but no players though.

minj commented 9 years ago

Comment #15 originally posted by convincedd on 2009-03-03T22:11:49.000Z:

try again

minj commented 9 years ago

Comment #16 originally posted by warheart_8 on 2009-03-03T22:21:59.000Z:

it's fixed on the time, but this is some example. I'll go from selectbox category to select transferlisted filter, ok it shows correctly everything, next time when I go transferlisted players, categories gets in mess. Pictures dont have such a problem.

minj commented 9 years ago

Comment #17 originally posted by warheart_8 on 2009-03-03T22:34:13.000Z:

I mean that every category works, but after some filtering it goes like this:

http://img3.imageshack.us/img3/2084/wewew2.jpg

minj commented 9 years ago

Comment #18 originally posted by convincedd on 2009-03-03T22:41:13.000Z:

i didn't realy understood you there. can you explaion it more step by step.

minj commented 9 years ago

Comment #19 originally posted by convincedd on 2009-03-03T22:45:45.000Z:

ah, i see. i'll have a look if i find something.

minj commented 9 years ago

Comment #20 originally posted by warheart_8 on 2009-03-03T22:48:46.000Z:

first when select category: http://img6.imageshack.us/img6/8048/wewewj.jpg I decide to check transferlisted: http://img228.imageshack.us/img228/6545/wewew1.jpg

After some filtering, I can see transferlisted like this: http://img3.imageshack.us/img3/2084/wewew2.jpg

And when no filters, it goes like this: http://img220.imageshack.us/img220/7907/wewew23.jpg

BUT, when I load player page again, and start filtering, this all starts from the beginning, like clean.

minj commented 9 years ago

Comment #21 originally posted by warheart_8 on 2009-03-03T22:50:41.000Z:

But i'm out now, I think there is no hurry to be fix this :)

minj commented 9 years ago

Comment #22 originally posted by convincedd on 2009-03-03T23:00:23.000Z:

you noticed that the thin line between players is missing on later pictures. i guess that might be the problem. the seperator is not turned on again. that should be fixable (if it's that)

minj commented 9 years ago

Comment #23 originally posted by ljushaff on 2009-03-03T23:07:25.000Z:

I'm available to test it if Leachey is offline ;)

minj commented 9 years ago

Comment #24 originally posted by convincedd on 2009-03-03T23:14:13.000Z:

should be fixed. but another thing. i'm a bit worried what happend with the ticker alert if you have several hattrick tabs open in firefox. could you make a small test. i make my own too

minj commented 9 years ago

Comment #25 originally posted by ljushaff on 2009-03-03T23:26:54.000Z:

Player Filters is definitely fixed. As regards the tecker alert, with two tas opened just one alert slder showed, which is correct.I will try now with thee and four tas opened just to make sure that there is no problem

minj commented 9 years ago

Comment #26 originally posted by ljushaff on 2009-03-03T23:31:01.000Z:

You were right to be worried, with four tabs opened, I got 3 notifications :(

minj commented 9 years ago

Comment #27 originally posted by convincedd on 2009-03-03T23:33:18.000Z:

i just tried with two tab and mails and that worked. strange that it gets a problem with more. off checking

minj commented 9 years ago

Comment #28 originally posted by convincedd on 2009-03-03T23:42:25.000Z:

i tried with some pages with ticker news, and there i got all alerts just once!?

minj commented 9 years ago

Comment #29 originally posted by ljushaff on 2009-03-03T23:46:07.000Z:

Strange indeed, I tried again with two and three respectively and it was fine (only one popup slider) But then when I tried with four tabs two popup slider appeared..

minj commented 9 years ago

Comment #30 originally posted by ljushaff on 2009-03-03T23:53:24.000Z:

Stop!!! Everything works fine. Now I realised thatthe second popup was spambots message to me on the same topic. Sorry for the confusion I made.

minj commented 9 years ago

Comment #31 originally posted by convincedd on 2009-03-03T23:55:35.000Z:

maybe there is something wrong with checking if an event is new. i'd have to understand that part of the code first though and its not a good idea to do that in the night. hence it will have to wait a little bit.

minj commented 9 years ago

Comment #32 originally posted by convincedd on 2009-03-03T23:57:44.000Z:

uff. ok. i better changed status of the issue to fixe right now, before anything new come up :) (ps i know that the come sometimes to fast behind each other to see them properly. have to check that another day if it is possible to fix)

minj commented 9 years ago

Comment #33 originally posted by ljushaff on 2009-03-04T00:05:51.000Z:

I dont think that this needs any improvement. As I said its me who overlooked that I received two replies one from my test message an the other one from spambot. I was thinking that thiese were two alerts for my test message. But I was wrong those were two separate alerts, one for my test and the other for spambots message to me which is correct as it should be.

minj commented 9 years ago

Comment #34 originally posted by convincedd on 2009-03-04T00:08:09.000Z:

well, then close for now. i need a break:)

Status: Fixed

minj commented 9 years ago

Comment #35 originally posted by ljushaff on 2009-03-04T10:23:08.000Z:

I had to reopen the issue, since the bug still shows on youth payers page whn sorted by category. The same as it used to be with seniors.

http://easycaptures.com/6257840968

I am also attaching the page source for youth players sorted by categories.

Status: Accepted

minj commented 9 years ago

Comment #36 originally posted by convincedd on 2009-03-04T10:34:58.000Z:

should be easier this time. though i don't know why on first glance.

minj commented 9 years ago

Comment #37 originally posted by convincedd on 2009-03-04T11:01:29.000Z:

fixed. so now we'd better have a look at NT.players :|

minj commented 9 years ago

Comment #38 originally posted by ljushaff on 2009-03-04T11:10:28.000Z:

No need to worry about NT players and "players raised in this team" there are no categories on those pages :))I've checked though just in cae and now its definitely fixed.

thanks ;)

Status: Done