minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
72 stars 48 forks source link

Remove last paragraph in CopyScoutReport #693

Closed minj closed 9 years ago

minj commented 9 years ago

Original issue 693 created by markus.pullmann on 2011-02-16T09:24:04.000Z:

What steps will reproduce the problem? call your scout and submit call in hattrick youthclub for rejected players

What is the expected behaviour? What is the actual behaviour instead? Well, all the time the last sentence of the scout call is copied too. But this sentence is always the same and therefore not needed. It irritates some users.

See attached file for the output foxtrick generates. The last sentence can be cut off ;)

Cheers, Markus

minj commented 9 years ago

Comment #1 originally posted by ryanlimigrate on 2011-02-17T03:36:44.000Z:

This issue was closed by fcd81ac552d84a807fb559b181dba8b22f2234bf r6040.

Status: Fixed

minj commented 9 years ago

Comment #2 originally posted by ryanlimigrate on 2011-02-17T03:38:15.000Z:

The last paragraph is always blank, so I removed the last two paragraphs in fcd81ac552d84a807fb559b181dba8b22f2234bf r6040. Hope it works but I cannot test it here.

Owner: [ryan](mailto:ryan@ryanium.com) Labels: -Type-Defect, -Priority-Medium, Type-Enhancement, Priority-Low

minj commented 9 years ago

Comment #3 originally posted by markus.pullmann on 2011-02-19T11:56:03.000Z:

You can remove two more lines at the end of the file. Because the last Sentence of the comment is always the same, and there is always an empty line before it! This would be great to see :) The lines with a ">" at the end can be removed without a loss of any information needed for youthclub:

Am Telefon: Hansjochen Wagenplatz Ja, bitte? Ah, hallo Mackshot!

Mir scheint, ich habe ein Nachwuchstalent für dich gefunden. Sein Name ist Xaver Sieber, und er ist 15 Jahre alt.

Ich würde seine Fähigkeiten in Spielaufbau zurzeit ungefähr auf schwach schätzen. Ehe du dich versiehst, könnte dieser Spieler in Torschuss schwach werden, falls du ihn richtig trainierst.

Sollen wir ihn unter Vertrag nehmen, Chef?