search

minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
71 stars 49 forks source link

OAuth failure feedback #788

Closed minj closed 9 years ago

minj commented 9 years ago

Original issue 788 created by convincedd on 2011-07-25T01:45:42.000Z:

there was none. was assumed to be fine. needs to be done properly. see also 41306143c024534427a3a5b9c3ec24ab8f1959eb r6844

minj commented 9 years ago

Comment #1 originally posted by ryan on 2011-07-25T07:24:34.000Z:

It's OAuth. :-) Also I thought I have added an "Error ***" message there?

Cc: [ryan](mailto:ryan@ryanium.com)

minj commented 9 years ago

Comment #2 originally posted by convincedd on 2011-07-25T10:29:10.000Z:

haven't found one. we could parse the hattrick error message there easily. would take a few minutes to do so

minj commented 9 years ago

Comment #3 originally posted by ryan on 2011-07-25T10:52:01.000Z:

content/util/api.js

ll. 59-63

minj commented 9 years ago

Comment #4 originally posted by convincedd on 2011-07-25T11:10:46.000Z:

can fail at different stages. here http://code.google.com/p/foxtrick/source/browse/trunk/content/util/api.js# 103 we use the token to authorize. if that token is outdated (which happens to me sometimes) then we get 401 error. for testing. request token & copy it. restart foxtrick and try to use that token to authorize

minj commented 9 years ago

Comment #5 originally posted by ryan on 2011-07-25T11:14:37.000Z:

Should use a unified way of showing that then. Just stick to that would be fine.

minj commented 9 years ago

Comment #6 originally posted by convincedd on 2011-07-25T18:35:59.000Z:

fixed with 66ccdc68d4b3ebb8f2d78c43cdcddbd04ea8fb87 r6853

Status: Fixed