minj / foxtrick

FoxTrick is a browser extension for the Hattrick online football manager game, currently available for Firefox, Google Chrome, as well as for Opera.
https://www.foxtrick.org
GNU General Public License v3.0
69 stars 48 forks source link

FoxtrickPrefs.isModuleOptionEnabled not 100% safe to use atm for nested options #996

Open minj opened 9 years ago

minj commented 9 years ago

Original issue 996 created by CatzHoek on 2012-08-17T21:32:16.000Z:

Since we can have groups of options that belong to a parent settings atm. this function does not give reliable information if an option is actually executed. The parent(s) still have to be checked as well.

For the prefs (setting the checkbox state etc.) it is completly fine, but for the use from other modules/parts of foxtrick it will not properly tell if a nested feature will actually run or not.

Guess i should do it myself since i m responsible for the issue but not sure when i get to it.

minj commented 9 years ago

Comment #1 originally posted by minj on 2013-06-02T17:19:05.000Z:

<empty>

Labels: Maintainability

minj commented 9 years ago

Comment #2 originally posted by minj on 2014-01-07T19:12:24.000Z:

<empty>

Labels: Preferences