Make "Scrutinizer CI" fail the build if new issues are found

[aik099]

Right now (after Scrutinizer CI no longer fails the build based on Travis CI) it's become more obvious that coding standard violations should mark build as failed.

To make this happen following needs to be added to repository config on Scrutinizer CI website (for this repository and each driver repository):

build_failure_conditions:
    - 'issues.new.exists'

[stof]

This is already done since 1 week, with a slightly more complex config (I don't fail if new duplication issues are found because we don't have a good config for the duplication detector yet): https://github.com/Behat/Mink/pull/623#discussion_r22211910 But we haven't had any PR updated since then to run with the new config. It is not yet done on driver repos though

[aik099]

I've just looked at latest inspection on Mink repo and it's config doesn't show any build failure conditions.

I guess you need to re-run inspections on all repos for config change to be reflected in inspection log. Then you can safely close this issue.

[stof]

This is because the latest inspection on Mink is before the config change.

[stof]

I will keep this issue opened until I update the config for all drivers

[stof]

here is how Scrutinizer looks when meeting a build failure: https://scrutinizer-ci.com/g/minkphp/Mink/inspections/89806a4c-fd0e-4049-9fba-0b8d5e6df7ac and it sets the github status to failure

[aik099]

OK.

[aik099]

https://github.com/minkphp/Mink/issues/628#issuecomment-68431538

@stof , has this (config for all drivers updated to support bailing the build) happened?

[stof]

@aik099 not done by me yet.

[stof]

Closing tis as Scrutinizer has been removed.