search

minkphp / Mink

PHP web browser emulator abstraction
https://mink.behat.org/
MIT License
1.6k stars 280 forks source link

Feature/allow phpunit 10 #841

Open Chris53897 opened 1 year ago

Chris53897 commented 1 year ago

The 2 abstract Test-Classes are excludet to nor raise Warnings and break CI-runs.

codecov[bot] commented 1 year ago

Codecov Report

Merging #841 (f04540b) into master (19e5890) will decrease coverage by 0.14%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #841      +/-   ##
============================================
- Coverage     98.47%   98.33%   -0.14%     
+ Complexity      345      344       -1     
============================================
  Files            23       23              
  Lines           983      903      -80     
============================================
- Hits            968      888      -80     
  Misses           15       15

see 17 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

aik099 commented 1 year ago

This PR also includes the changes from #842 . Not sure if that was planned.

Chris53897 commented 1 year ago

@aik099 Yes this in intended, please see https://github.com/minkphp/Mink/pull/841#discussion_r1192433462 This PR could be rebased after the bridge symfony/phpunit-bridge is compatible with PHPUnit 10.